Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2841633004: [regexp] Fix passing all flags to RegExp construction (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang, mathias
CC:
v8-reviews_googlegroups.com, mathias
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix passing all flags to RegExp construction Do not bail out when passed a flags string with length > 5, use a meaningful named constant instead. Found by https://github.com/tc39/test262/pull/997#issuecomment-296963675 BUG=v8:6300 Review-Url: https://codereview.chromium.org/2841633004 Cr-Commit-Position: refs/heads/master@{#44834} Committed: https://chromium.googlesource.com/v8/v8/+/a1af3315a2804fe21c575f45872350b958878e24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-dotall.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jgruber
3 years, 8 months ago (2017-04-25 09:19:56 UTC) #4
Yang
On 2017/04/25 09:19:56, jgruber wrote: lgtm.
3 years, 8 months ago (2017-04-25 09:21:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841633004/1
3 years, 8 months ago (2017-04-25 09:32:04 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 09:35:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a1af3315a2804fe21c575f45872350b9588...

Powered by Google App Engine
This is Rietveld 408576698