Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2841633002: Add SK_IGNORE_GASP_VERSION_CHECK to Skia build. (Closed)

Created:
3 years, 8 months ago by bungeman-chromium
Modified:
3 years, 8 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_IGNORE_GASP_VERSION_CHECK to Skia build. This will hold out a Skia change until after the change has rolled into Chromium for rebaselining. The Skia change can currently be found at https://skia-review.googlesource.com/c/13863 . BUG=chromium:713942 Review-Url: https://codereview.chromium.org/2841633002 Cr-Commit-Position: refs/heads/master@{#466684} Committed: https://chromium.googlesource.com/chromium/src/+/089a56f650525401088f9eae694bdef7efa0ddee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
bungeman-chromium
3 years, 8 months ago (2017-04-24 17:00:00 UTC) #4
f(malita)
lgtm
3 years, 8 months ago (2017-04-24 17:01:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841633002/1
3 years, 8 months ago (2017-04-24 17:05:56 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:10:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/089a56f650525401088f9eae694b...

Powered by Google App Engine
This is Rietveld 408576698