Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2841623004: Adding opt out and previews type information to DRP pingback (Closed)

Created:
3 years, 8 months ago by RyanSturm
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Adding opt out and previews type information to DRP pingback This CL adds the previews type that was shown for a page load and also reports when a page load was an opt out (clicked show original). Due to backgrounding behavior, when app background occurs or there is not a previews shown a third opt out state of unknown is reported. LoFi page state is determined if any subresources were LoFi images. Lite page uses the main resource to determine preview state. BUG=713236 Review-Url: https://codereview.chromium.org/2833523002 Cr-Commit-Position: refs/heads/master@{#466376} (cherry picked from commit 6ffce94e929ce46e50e364b726e07e2b4773c82b) Review-Url: https://codereview.chromium.org/2841623004 . Cr-Commit-Position: refs/branch-heads/3071@{#165} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/54667fee87a5328ebda89064a3c2bfb7864f64b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+818 lines, -182 lines) Patch
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.h View 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc View 5 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc View 8 chunks +56 lines, -20 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.h View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/previews/previews_infobar_delegate.cc View 2 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/previews/previews_infobar_delegate_unittest.cc View 7 chunks +102 lines, -0 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.h View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper.cc View 5 chunks +45 lines, -5 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h View 4 chunks +21 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc View 4 chunks +25 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 1 chunk +9 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 2 chunks +30 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.h View 5 chunks +23 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc View 6 chunks +60 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc View 17 chunks +246 lines, -39 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/proto/pageload_metrics.proto View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
RyanSturm
3 years, 8 months ago (2017-04-24 17:04:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
54667fee87a5328ebda89064a3c2bfb7864f64b8.

Powered by Google App Engine
This is Rietveld 408576698