mojo/common/values_struct_traits.h - Issue 2841623003: Remove base::Value::Get{Buffer,Size}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/values_struct_traits.h

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)

Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/values_struct_traits.h

diff --git a/mojo/common/values_struct_traits.h b/mojo/common/values_struct_traits.h

index 7d8c2ed72171c09e1c76170fd1b38deac40a6441..c9cd09e07262ee653ca7515b400d8b0f29f83ccf 100644

--- a/mojo/common/values_struct_traits.h

+++ b/mojo/common/values_struct_traits.h

@@ -177,8 +177,8 @@ struct UnionTraits<common::mojom::ValueDataView, base::Value> {

if (!value.GetAsBinary(&binary_value))

NOTREACHED();

return mojo::ConstCArray<uint8_t>(

- binary_value->GetSize(),

- reinterpret_cast<const uint8_t*>(binary_value->GetBuffer()));

+ binary_value->GetBlob().size(),

+ reinterpret_cast<const uint8_t*>(binary_value->GetBlob().data()));

}

static const base::ListValue& list_value(const base::Value& value) {