chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc - Issue 2841623003: Remove base::Value::Get{Buffer,Size}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)

Patch Set: std::vector::assign instead of std::vector::operator= Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc ('k') | chrome/browser/extensions/api/idltest/idltest_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

index 29bda417906ba8535cdd39c37a2f590c38aeee3d..31338257998cc7aa8e5c6aa8da148e437cb168ab 100644

--- a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

@@ -392,8 +392,8 @@ TEST_F(EPKChallengeMachineKeyTest, Success) {

const base::Value* response;

ASSERT_TRUE(value->GetAsBinary(&response));

- EXPECT_EQ("response",

- std::string(response->GetBuffer(), response->GetSize()));

+ EXPECT_EQ("response", std::string(response->GetBlob().data(),

+ response->GetBlob().size()));

}

TEST_F(EPKChallengeMachineKeyTest, KeyRegisteredSuccess) {

@@ -422,8 +422,8 @@ TEST_F(EPKChallengeMachineKeyTest, KeyRegisteredSuccess) {

const base::Value* response;

ASSERT_TRUE(value->GetAsBinary(&response));

- EXPECT_EQ("response",

- std::string(response->GetBuffer(), response->GetSize()));

+ EXPECT_EQ("response", std::string(response->GetBlob().data(),

+ response->GetBlob().size()));

}

TEST_F(EPKChallengeMachineKeyTest, AttestationNotPrepared) {

@@ -597,8 +597,8 @@ TEST_F(EPKChallengeUserKeyTest, Success) {

const base::Value* response;

ASSERT_TRUE(value->GetAsBinary(&response));

- EXPECT_EQ("response",

- std::string(response->GetBuffer(), response->GetSize()));

+ EXPECT_EQ("response", std::string(response->GetBlob().data(),

+ response->GetBlob().size()));

}

TEST_F(EPKChallengeUserKeyTest, AttestationNotPrepared) {