chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc - Issue 2841623003: Remove base::Value::Get{Buffer,Size}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 2841623003: Remove base::Value::Get{Buffer,Size} (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

index 866e14da134370af8b22f86e043b912ca7e42a1a..a50ec1249edf60e7941c5998f542f64ea98a54e1 100644

--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

@@ -77,8 +77,8 @@ void StoreDigest(std::vector<uint8_t>* digest,

EXPECT_TRUE(is_binary) << "Unexpected value in StoreDigest";

if (is_binary) {

const uint8_t* const binary_begin =

- reinterpret_cast<const uint8_t*>(binary->GetBuffer());

- digest->assign(binary_begin, binary_begin + binary->GetSize());

+ reinterpret_cast<const uint8_t*>(binary->GetBlob().data());

+ digest->assign(binary_begin, binary_begin + binary->GetBlob().size());

Devlin 2017/04/24 18:18:45 does *digest = binary->GetBlob() work? Or does a

jdoerrie 2017/04/25 08:50:33 Done. I was indeed afraid that the compiler would

}

callback.Run();