Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2841603005: gcapi_mac: Add gn build file. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gcapi_mac: Add gn build file. BUG=715131 Review-Url: https://codereview.chromium.org/2841603005 Cr-Commit-Position: refs/heads/master@{#467128} Committed: https://chromium.googlesource.com/chromium/src/+/dc11faf5dde4def76a9926f4466b3bd8808ba6ab

Patch Set 1 #

Total comments: 4

Patch Set 2 : leeeeeeeopard jenkins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/installer/gcapi_mac/BUILD.gn View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
3 years, 8 months ago (2017-04-25 19:22:59 UTC) #3
Mark Mentovai
https://codereview.chromium.org/2841603005/diff/1/chrome/installer/gcapi_mac/BUILD.gn File chrome/installer/gcapi_mac/BUILD.gn (right): https://codereview.chromium.org/2841603005/diff/1/chrome/installer/gcapi_mac/BUILD.gn#newcode22 chrome/installer/gcapi_mac/BUILD.gn:22: "-mmacosx-version-min=10.8", Was this at 10.8 when we deleted the ...
3 years, 8 months ago (2017-04-25 20:08:55 UTC) #5
Nico
https://codereview.chromium.org/2841603005/diff/1/chrome/installer/gcapi_mac/BUILD.gn File chrome/installer/gcapi_mac/BUILD.gn (right): https://codereview.chromium.org/2841603005/diff/1/chrome/installer/gcapi_mac/BUILD.gn#newcode22 chrome/installer/gcapi_mac/BUILD.gn:22: "-mmacosx-version-min=10.8", On 2017/04/25 20:08:55, Mark Mentovai wrote: > Was ...
3 years, 8 months ago (2017-04-25 20:13:49 UTC) #7
Mark Mentovai
LGTM
3 years, 8 months ago (2017-04-25 20:25:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841603005/20001
3 years, 8 months ago (2017-04-25 20:27:51 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:49:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc11faf5dde4def76a9926f4466b...

Powered by Google App Engine
This is Rietveld 408576698