third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp - Issue 2841603003: Record non-stacking-context as main thread scrolling reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

Issue 2841603003: Record non-stacking-context as main thread scrolling reasons (Closed)

Patch Set: Only keep the NonStackingContext reason Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp b/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

index 9f344d0c037d3930a99c02cd583bf0ea6163e631..7e45c685863967f955cad0c11152ac04e66e3b31 100644

--- a/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

@@ -347,9 +347,11 @@ TEST_F(NonCompositedMainThreadScrollingReasonRecordTest, NestedScrollersTest) {

// areas from the chain have corresponding reasons.

EXPECT_WHEEL_BUCKET(kHasOpacityAndLCDText, 1);

EXPECT_WHEEL_BUCKET(kBackgroundNotOpaqueInRectAndLCDText, 1);

+ EXPECT_WHEEL_BUCKET(kIsNotStackingContextAndLCDText, 1);

EXPECT_WHEEL_BUCKET(kHasBorderRadius, 1);

flackr 2017/04/28 17:36:58 nit: Remove extra line

yigu 2017/04/28 17:50:09 Done.

EXPECT_WHEEL_BUCKET(kHasTransformAndLCDText, 0);

- EXPECT_WHEEL_TOTAL(3);

+ EXPECT_WHEEL_TOTAL(4);

}

} // namespace