Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp

Issue 2841603003: Record non-stacking-context as main thread scrolling reasons (Closed)
Patch Set: Only keep the NonStackingContext reason Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ClientRect.h" 5 #include "core/dom/ClientRect.h"
6 #include "core/frame/FrameView.h" 6 #include "core/frame/FrameView.h"
7 #include "core/input/EventHandler.h" 7 #include "core/input/EventHandler.h"
8 #include "core/layout/LayoutView.h" 8 #include "core/layout/LayoutView.h"
9 #include "core/paint/PaintLayerScrollableArea.h" 9 #include "core/paint/PaintLayerScrollableArea.h"
10 #include "platform/scroll/MainThreadScrollingReason.h" 10 #include "platform/scroll/MainThreadScrollingReason.h"
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 340
341 Element* box = GetDocument().getElementById("inner"); 341 Element* box = GetDocument().getElementById("inner");
342 HistogramTester histogram_tester; 342 HistogramTester histogram_tester;
343 343
344 Scroll(box, kWebGestureDeviceTouchpad); 344 Scroll(box, kWebGestureDeviceTouchpad);
345 // Scrolling the inner box will gather reasons from the scrolling chain. The 345 // Scrolling the inner box will gather reasons from the scrolling chain. The
346 // inner box itself has no reason because it's composited. Other scrollable 346 // inner box itself has no reason because it's composited. Other scrollable
347 // areas from the chain have corresponding reasons. 347 // areas from the chain have corresponding reasons.
348 EXPECT_WHEEL_BUCKET(kHasOpacityAndLCDText, 1); 348 EXPECT_WHEEL_BUCKET(kHasOpacityAndLCDText, 1);
349 EXPECT_WHEEL_BUCKET(kBackgroundNotOpaqueInRectAndLCDText, 1); 349 EXPECT_WHEEL_BUCKET(kBackgroundNotOpaqueInRectAndLCDText, 1);
350 EXPECT_WHEEL_BUCKET(kIsNotStackingContextAndLCDText, 1);
350 EXPECT_WHEEL_BUCKET(kHasBorderRadius, 1); 351 EXPECT_WHEEL_BUCKET(kHasBorderRadius, 1);
352
flackr 2017/04/28 17:36:58 nit: Remove extra line
yigu 2017/04/28 17:50:09 Done.
351 EXPECT_WHEEL_BUCKET(kHasTransformAndLCDText, 0); 353 EXPECT_WHEEL_BUCKET(kHasTransformAndLCDText, 0);
352 EXPECT_WHEEL_TOTAL(3); 354 EXPECT_WHEEL_TOTAL(4);
353 } 355 }
354 356
355 } // namespace 357 } // namespace
356 358
357 } // namespace blink 359 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698