Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2841603002: Clear browsing data ui fixes (Closed)

Created:
3 years, 8 months ago by dullweber
Modified:
3 years, 8 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear browsing data ui fixes Increase PreferenceSpinner touch target Increase PreferenceSpinner paddingEnd on tablets Small changes of PreferenceSpinner paddings to match specs more closely Increase clear button paddingEnd on tablets Make divider preference non-selectable Before (Nexus 9): https://screenshot.googleplex.com/Xea6XfxNYWR.png After: https://screenshot.googleplex.com/yH4BVmjY6OP.png BUG=681523 Review-Url: https://codereview.chromium.org/2841603002 Cr-Commit-Position: refs/heads/master@{#466637} Committed: https://chromium.googlesource.com/chromium/src/+/9866fbdfef0d5a24dae8d0e2519a973a8262448f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M chrome/android/java/res/layout-sw360dp/preference_spinner_single_line.xml View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/clear_browsing_data_tab_content.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values-sw600dp/dimens.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/xml/clear_browsing_data_preferences_tab.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
dullweber
Hi, here is another small cl with layout improvements for CBD. Could you take a ...
3 years, 8 months ago (2017-04-24 14:37:48 UTC) #4
Theresa
lgtm
3 years, 8 months ago (2017-04-24 15:20:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841603002/1
3 years, 8 months ago (2017-04-24 15:24:08 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 16:07:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9866fbdfef0d5a24dae8d0e2519a...

Powered by Google App Engine
This is Rietveld 408576698