changed ordering of context menu to display image/video tab before link tab

changed ordering of context menu to display image/video tab before link tab

moved isAnchor if statement to after isImage & isVideo

BUG=655359
Review-Url: https://codereview.chromium.org/2841543003
Cr-Commit-Position: refs/heads/master@{#470427}
Committed: https://chromium.googlesource.com/chromium/src/+/830937ec4ec791325c178c119566b6ec88632449

[Daniel Park, 2017-04-24 18:43:52]

Description was changed from

==========
changed ordering of context menu to display image/video tab before link tab

moved isAnchor if statement to after isImage & isVideo

BUG=655359
==========

to

==========
changed ordering of context menu to display image/video tab before link tab

moved isAnchor if statement to after isImage & isVideo

BUG=655359
==========

[Daniel Park, 2017-04-24 18:43:52]

danielpark@chromium.org changed reviewers:
+ dfalcantara@chromium.org, jwanda@chromium.org

[Daniel Park, 2017-04-24 18:44:02]

danielpark@chromium.org changed reviewers:
+ danielpark@chromium.org

[gone, 2017-04-24 18:48:49]

lgtm

[JJ, 2017-04-24 20:11:59]

Super quick question. Does the order change when using the
"PlatformContextMenu"? I remember we left it like that because of that flip but
that could have changed.

[gone, 2017-04-24 20:15:16]

On 2017/04/24 20:11:59, JJ wrote:
> Super quick question. Does the order change when using the
> "PlatformContextMenu"? I remember we left it like that because of that flip
but
> that could have changed.

Was Theresa the one who was reviewing all of your CLs before?  Would she know?

[chromium-reviews, 2017-04-24 20:46:05]

These were done by Ted and David, actually

On Mon, Apr 24, 2017, 1:15 PM <dfalcantara@chromium.org> wrote:

> On 2017/04/24 20:11:59, JJ wrote:
> > Super quick question. Does the order change when using the
> > "PlatformContextMenu"? I remember we left it like that because of that
> flip
> but
> > that could have changed.
>
> Was Theresa the one who was reviewing all of your CLs before? Would she
> know?
>
> https://codereview.chromium.org/2841543003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Park, 2017-04-24 22:55:31]

one small change to the xml file

[Daniel Park, 2017-04-26 00:27:05]

The CQ bit was checked by danielpark@chromium.org

[Daniel Park, 2017-04-26 00:27:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2841543003/#ps40001
(title: "updated tab layout for imagelink & videolink menus")

[Daniel Park, 2017-04-26 00:27:24]

The CQ bit was unchecked by danielpark@chromium.org

[Daniel Park, 2017-05-05 18:47:58]

https://codereview.chromium.org/2841543003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2841543003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:301:
: 0;
assuming the content long pressed were solely a link, image, or video,
groupedItems will only have one element, so groupedItems.size() - 1 == 0.

note: in the base version, the ordering of groupedItems would be 
1. Link
2. Image/Video

in the new version, the ordering is 
1. Image/Video
2. Link

now, assuming an imagelink were pressed, in the old version, groupedItems.size()
- 1 would be the index of the Image/video & 0 would be the index of the link.
in the new version, groupedItems.size() - 1 is the Link & 0 is the Image/Video.

[gone, 2017-05-08 17:47:02]

still lgtm

[JJ, 2017-05-08 18:18:55]

lgtm

[Daniel Park, 2017-05-08 22:33:13]

The CQ bit was checked by danielpark@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:37:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 00:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:23:34]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Daniel Park, 2017-05-09 19:21:53]

The CQ bit was checked by danielpark@chromium.org

[commit-bot: I haz the power, 2017-05-09 19:23:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 22:10:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494357713948140,
"parent_rev": "36388974520e22c554b2f57e38ede28a6260293d", "commit_rev":
"830937ec4ec791325c178c119566b6ec88632449"}

[commit-bot: I haz the power, 2017-05-09 22:10:14]

Description was changed from

==========
changed ordering of context menu to display image/video tab before link tab

moved isAnchor if statement to after isImage & isVideo

BUG=655359
==========

to

==========
changed ordering of context menu to display image/video tab before link tab

moved isAnchor if statement to after isImage & isVideo

BUG=655359

Review-Url: https://codereview.chromium.org/2841543003
Cr-Commit-Position: refs/heads/master@{#470427}
Committed:
https://chromium.googlesource.com/chromium/src/+/830937ec4ec791325c178c119566...
==========

[commit-bot: I haz the power, 2017-05-09 22:10:15]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/830937ec4ec791325c178c119566...