[debug] additional checks for built-ins calling runtime functions.

[debug] additional checks for built-ins calling runtime functions.

R=jgruber@chromium.org
BUG=v8:5821
Review-Url: https://codereview.chromium.org/2841513002
Cr-Commit-Position: refs/heads/master@{#44796}
Committed: https://chromium.googlesource.com/v8/v8/+/6a833f23af8d27d8ccca1ddbb0c1ff6619d969ef

[jgruber, 2017-04-24 09:05:54]

https://codereview.chromium.org/2841513002/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2841513002/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:687: // CHECK(!failed);
Shouldn't this be enabled?

https://codereview.chromium.org/2841513002/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/2841513002/diff/1/test/cctest/test-debug.cc#n...
test/cctest/test-debug.cc:6737: if (failed) isolate->clear_pending_exception();
I suppose the test currently depends on the CHECK in the side effect check? A
comment would make that clearer.

[Yang, 2017-04-24 11:48:01]

https://codereview.chromium.org/2841513002/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2841513002/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:687: // CHECK(!failed);
On 2017/04/24 09:05:54, jgruber wrote:
> Shouldn't this be enabled?

Thanks for catching this!

https://codereview.chromium.org/2841513002/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/2841513002/diff/1/test/cctest/test-debug.cc#n...
test/cctest/test-debug.cc:6737: if (failed) isolate->clear_pending_exception();
On 2017/04/24 09:05:54, jgruber wrote:
> I suppose the test currently depends on the CHECK in the side effect check? A
> comment would make that clearer.

Changed comment.

[Yang, 2017-04-24 11:48:04]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-24 11:48:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 11:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 11:48:16]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[jgruber, 2017-04-24 11:56:23]

lgtm

[Yang, 2017-04-24 12:56:06]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-24 12:56:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 13:21:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493038566454890,
"parent_rev": "e8f1fc24fda7ce3e75a29fbae13db78a182e15df", "commit_rev":
"6a833f23af8d27d8ccca1ddbb0c1ff6619d969ef"}

[commit-bot: I haz the power, 2017-04-24 13:21:57]

Description was changed from

==========
[debug] additional checks for built-ins calling runtime functions.

R=jgruber@chromium.org
BUG=v8:5821
==========

to

==========
[debug] additional checks for built-ins calling runtime functions.

R=jgruber@chromium.org
BUG=v8:5821

Review-Url: https://codereview.chromium.org/2841513002
Cr-Commit-Position: refs/heads/master@{#44796}
Committed:
https://chromium.googlesource.com/v8/v8/+/6a833f23af8d27d8ccca1ddbb0c1ff6619d...
==========

[commit-bot: I haz the power, 2017-04-24 13:21:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/6a833f23af8d27d8ccca1ddbb0c1ff6619d...