Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp

Issue 2841473002: Implement HTMLMenuItemElement.label (Closed)
Patch Set: Reflect review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
diff --git a/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp b/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
index bbfe4bc7864dc3dc3c5e7f5e09fc675d83b12193..561c647a807eea825b3597223e1891ad4fca6a77 100644
--- a/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
+++ b/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
@@ -69,7 +69,7 @@ void CustomContextMenuProvider::AppendSeparator(ContextMenu& context_menu) {
void CustomContextMenuProvider::AppendMenuItem(HTMLMenuItemElement* menu_item,
ContextMenu& context_menu) {
// Avoid menuitems with no label.
- String label_string = menu_item->FastGetAttribute(labelAttr);
+ String label_string = menu_item->label();
tkent 2017/04/26 08:59:58 Can you check Firefox behavior for <menuitem label
yuzuchan 2017/04/26 10:28:30 Firefox does not render the menuitem when label is
if (label_string.IsEmpty())
return;

Powered by Google App Engine
This is Rietveld 408576698