Implement HTMLMenuItemElement.label

third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/page/CustomContextMenuProvider.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/events/EventDispatcher.h"
 #include "core/events/MouseEvent.h"
@@ skipping 51 matching lines @@
   if (last_item.GetType() == kSeparatorType)
     return;
 
   context_menu.AppendItem(ContextMenuItem(
       kSeparatorType, kContextMenuItemCustomTagNoAction, String(), String()));
 }
 
 void CustomContextMenuProvider::AppendMenuItem(HTMLMenuItemElement* menu_item,
                                                ContextMenu& context_menu) {
   // Avoid menuitems with no label.
-  String label_string = menu_item->FastGetAttribute(labelAttr);
+  String label_string = menu_item->label();

[tkent, 2017/04/26 08:59:58]

Can you check Firefox behavior for <menuitem label="">text content</menuitem>? 
If Firefox shows "text content" in the menu, it uses conceptualLabel() here.

[yuzuchan, 2017/04/26 10:28:30]

Firefox does not render the menuitem when label is empty and text content
exists, 
which means label is set to an empty string.
To match the behavior I'll keep it this way here.

   if (label_string.IsEmpty())
     return;
 
   menu_items_.push_back(menu_item);
 
   bool enabled = !menu_item->FastHasAttribute(disabledAttr);
   String icon = menu_item->FastGetAttribute(iconAttr);
   if (!icon.IsEmpty()) {
     // To obtain the absolute URL of the icon when the attribute's value is not
     // the empty string, the attribute's value must be resolved relative to the
@@ skipping 57 matching lines @@
 
 HTMLElement* CustomContextMenuProvider::MenuItemAt(unsigned menu_id) {
   int item_index = menu_id - kContextMenuItemBaseCustomTag;
   if (item_index < 0 ||
       static_cast<unsigned long>(item_index) >= menu_items_.size())
     return nullptr;
   return menu_items_[item_index].Get();
 }
 
 }  // namespace blink