Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2841453002: Generate StyleVisualData in ComputedStyleBase. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
nainar, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate StyleVisualData in ComputedStyleBase. This patch generates the following fields as part of a group: - clip ('storage_only' of type LengthBox) - HasAutoClip ('storage_only' of type bool) - text-decoration ('storage_only' of enum type TextDecoration) - zoom ('storage_only' of type float) Since HasAutoClip doesn't correspond to a CSS property, we specify it in ComputedStyleExtraFields.json5. Furthermore, text-decoration is a keyword CSS property, but it can take on any subset of values from a set of keywords. We can't generate this kind of fields yet. Instead of complicating this patch with the generation of text-decoration, we will specify it as a storage_only field in ComputedStyleExtraFields.json5 with a field size of 4 bits (we can't specify it in CSSProperties.json5 since that file doesn't support field sizes). A future patch will generate text-decoration properly. Diff of generated files: https://gist.github.com/b3420eb4c3d0514cd4f1f936181fedb6/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2841453002 Cr-Commit-Position: refs/heads/master@{#469939} Committed: https://chromium.googlesource.com/chromium/src/+/60bc5e0281871949b67b8d7d3a2f0bc3db72f98c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -135 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 5 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 6 chunks +5 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleVisualData.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleVisualData.cpp View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 35 (30 generated)
shend
Hi Naina, PTAL
3 years, 8 months ago (2017-04-24 07:16:01 UTC) #10
nainar
YEAH! \o/ LGTM
3 years, 8 months ago (2017-04-24 09:52:40 UTC) #11
rune
rs lgtm
3 years, 7 months ago (2017-04-26 08:57:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841453002/60001
3 years, 7 months ago (2017-05-08 08:11:42 UTC) #32
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:46:03 UTC) #35
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/60bc5e0281871949b67b8d7d3a2f...

Powered by Google App Engine
This is Rietveld 408576698