Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2841403003: 📰 Properly implement scroll to top on sheet open (Closed)

Created:
3 years, 7 months ago by dgn
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Properly implement scroll to top on sheet open Fix https://crrev.com/aee5ec5b3423c48e79c296a054636d60473cfa8d BUG=704700, 711414 Review-Url: https://codereview.chromium.org/2841403003 Cr-Commit-Position: refs/heads/master@{#467823} Committed: https://chromium.googlesource.com/chromium/src/+/669b2d46e328fc884ff62d0d7c9a1a1e1c97e79b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL. After https://crrev.com/d869aacb31c99a19c08343fa449dce8023f0c206 we stop resetting the bottom sheet, which showed that the scroll to ...
3 years, 7 months ago (2017-04-27 21:53:32 UTC) #5
mdjones
lgtm
3 years, 7 months ago (2017-04-27 22:10:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841403003/1
3 years, 7 months ago (2017-04-27 22:29:30 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:57:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/669b2d46e328fc884ff62d0d7c9a...

Powered by Google App Engine
This is Rietveld 408576698