Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2841393003: createElementNS() should now throw only InvalidCharacterError, not NamespaceError (Closed)

Created:
3 years, 7 months ago by Shanmuga Pandi
Modified:
3 years, 7 months ago
Reviewers:
tkent, fs, foolip
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

createElementNS() should now throw only InvalidCharacterError, not NamespaceError Validating a qualified name should only throw InvalidCharacterError, not NamespaceError, after: https://github.com/whatwg/dom/issues/319 https://github.com/w3c/web-platform-tests/issues/5161 https://github.com/whatwg/dom/issues/423 Latest spec: https://dom.spec.whatwg.org/#validate Webkit Patch: http://trac.webkit.org/changeset/215701/webkit BUG=702077 Review-Url: https://codereview.chromium.org/2841393003 Cr-Commit-Position: refs/heads/master@{#467936} Committed: https://chromium.googlesource.com/chromium/src/+/423b422b6ce147aa3bb4858ab498802751c52c9b

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1157 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt View 1 1 chunk +0 lines, -395 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocumentType-expected.txt View 1 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElementNS-expected.txt View 1 1 chunk +0 lines, -585 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/attributes-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/DOMImplementation/createDocumentType-err.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/DOMImplementation/createDocumentType-err-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Document/createAttributeNS-namespace-err.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Document/createAttributeNS-namespace-err-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Document/createElementNS-namespace-err.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Document/createElementNS-namespace-err-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Element/setAttributeNS-namespace-err.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Element/setAttributeNS-namespace-err-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/acid3.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Shanmuga Pandi
PTAL !! Thanks
3 years, 7 months ago (2017-04-28 05:49:36 UTC) #11
tkent
Because this changes a long-standing behavior, would you make a chromestatus.com entry please? I think ...
3 years, 7 months ago (2017-04-28 06:22:53 UTC) #12
Shanmuga Pandi
On 2017/04/28 06:22:53, tkent wrote: > Because this changes a long-standing behavior, would you make ...
3 years, 7 months ago (2017-04-28 06:45:47 UTC) #13
tkent
lgtm
3 years, 7 months ago (2017-04-28 07:43:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841393003/20001
3 years, 7 months ago (2017-04-28 08:40:18 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 08:47:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/423b422b6ce147aa3bb4858ab498...

Powered by Google App Engine
This is Rietveld 408576698