Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2841383002: Reenable heap compaction after r466956 (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable heap compaction after r466956 BUG=699269 Review-Url: https://codereview.chromium.org/2841383002 Cr-Commit-Position: refs/heads/master@{#467629} Committed: https://chromium.googlesource.com/chromium/src/+/6ad875d22992e6bf124245d186ac9e19fdfafb96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/heap/HeapCompact.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
keishi
HeapCompact is disabled for 60.0.3081.0 and 60.0.3082.0. We don't have any crash reports yet but ...
3 years, 8 months ago (2017-04-27 05:16:45 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-27 05:18:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841383002/1
3 years, 8 months ago (2017-04-27 06:35:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 10:06:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ad875d22992e6bf124245d186ac...

Powered by Google App Engine
This is Rietveld 408576698