Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2841373002:
[autoroll] add tests for autoroll subcommand parsing. (Closed)
|
Created:
3 years, 8 months ago by iannucci Modified:
3 years, 7 months ago CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org Target Ref:
refs/heads/master Project:
recipe_engine Visibility:
Public. |
Description[autoroll] add tests for autoroll subcommand parsing.
Also convert output-json to a argparse.FileType while I'm at it.
R=dnj@chromium.org, phajdan.jr@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2841373002
Committed: https://github.com/luci/recipes-py/commit/aa45f3d6a7daaf1d32c1efeda9645e2f134fc959
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : vendored argparse #
Total comments: 2
Patch Set 5 : rebase #Patch Set 6 : close file #Messages
Total messages: 32 (26 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c62e16ccfc4710)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/35c6784cc4eae210)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2841373002/diff/60001/recipe_engine/autoroll.py File recipe_engine/autoroll.py (right): https://codereview.chromium.org/2841373002/diff/60001/recipe_engine/autoroll.... recipe_engine/autoroll.py:277: type=argparse.FileType('w'), I think we should explicitly close this when we're done, now. Also, this file will be created even if an error happens before it is written. Probably not a big deal though.
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [autoroll] add tests for autoroll subcommand parsing. Also convert output-json to a argpars.FileType while I'm at it. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ========== to ========== [autoroll] add tests for autoroll subcommand parsing. Also convert output-json to a argparse.FileType while I'm at it. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ==========
https://codereview.chromium.org/2841373002/diff/60001/recipe_engine/autoroll.py File recipe_engine/autoroll.py (right): https://codereview.chromium.org/2841373002/diff/60001/recipe_engine/autoroll.... recipe_engine/autoroll.py:277: type=argparse.FileType('w'), On 2017/04/27 17:19:03, dnj wrote: > I think we should explicitly close this when we're done, now. Also, this file > will be created even if an error happens before it is written. Probably not a > big deal though. Done.
The CQ bit was checked by iannucci@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2841373002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
The CQ bit was checked by iannucci@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2841373002/#ps100001 (title: "close file")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493490893118000,
"parent_rev": "73d1232b112d420c35023b2c8536f7f473cc61d0", "commit_rev":
"aa45f3d6a7daaf1d32c1efeda9645e2f134fc959"}
Message was sent while issue was closed.
Description was changed from ========== [autoroll] add tests for autoroll subcommand parsing. Also convert output-json to a argparse.FileType while I'm at it. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= ========== to ========== [autoroll] add tests for autoroll subcommand parsing. Also convert output-json to a argparse.FileType while I'm at it. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2841373002 Committed: https://github.com/luci/recipes-py/commit/aa45f3d6a7daaf1d32c1efeda9645e2f134... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://github.com/luci/recipes-py/commit/aa45f3d6a7daaf1d32c1efeda9645e2f134... |
