VR: Make webVR insecure content warning look more like M58 warning.

VR: Make webVR insecure content warning look more like M58 warning.

This removes the info icon from the transient warning, and adjusts the element sizes and font sizes to more closely align with M58.

BUG=

Review-Url: https://codereview.chromium.org/2841333003
Cr-Commit-Position: refs/heads/master@{#468130}
Committed: https://chromium.googlesource.com/chromium/src/+/df3332994e58f25503cf5974b50faf9625ab7435

[mthiesse, 2017-04-27 14:35:25]

mthiesse@chromium.org changed reviewers:
+ acondor@google.com, cjgrant@chromium.org

[mthiesse, 2017-04-27 14:35:26]

PTAL

[acondor_, 2017-04-27 16:09:50]

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
File
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
(right):

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc:59:
canvas->Translate(gfx::Vector2d(IsRTL() ? kBorderFactor * size_.width()
There's no need to distinguish between RTL and LTR now.

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc:70:
return gfx::Size(maximum_width, maximum_width);
It might be possible to fit everything in half the height, but I'm not sure.

[mthiesse, 2017-04-27 16:58:07]

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
File
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
(right):

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc:59:
canvas->Translate(gfx::Vector2d(IsRTL() ? kBorderFactor * size_.width()
On 2017/04/27 16:09:50, acondor wrote:
> There's no need to distinguish between RTL and LTR now.

Done.

https://codereview.chromium.org/2841333003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc:70:
return gfx::Size(maximum_width, maximum_width);
On 2017/04/27 16:09:50, acondor wrote:
> It might be possible to fit everything in half the height, but I'm not sure.

I'd rather be on the safe side and ensure we have more than enough space for any
possible translation. The temporary extra canvas size here probably has a
negligible effect on performance.

[cjgrant, 2017-04-28 17:35:13]

lgtm

lgtm after one tweak.

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:39: element->size = {0.224f,
0.070f, 1};
Should join the set of constants above.

[amp, 2017-04-28 18:01:34]

amp@chromium.org changed reviewers:
+ amp@chromium.org

[amp, 2017-04-28 18:01:35]

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:39: element->size = {0.224f,
0.070f, 1};
On 2017/04/28 17:35:13, cjgrant wrote:
> Should join the set of constants above.

Looks like this just hasn't been rebased yet.  This was already replaced with a
constant.

[mthiesse, 2017-04-28 18:30:23]

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2841333003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:39: element->size = {0.224f,
0.070f, 1};
On 2017/04/28 17:35:13, cjgrant wrote:
> Should join the set of constants above.

Done.

[mthiesse, 2017-04-28 18:30:26]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-04-28 18:30:27]

The patchset sent to the CQ was uploaded after l-g-t-m from cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2841333003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-28 18:32:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amp, 2017-04-28 19:36:50]

https://codereview.chromium.org/2841333003/diff/40001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2841333003/diff/40001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:188: bool enabled =
web_vr_mode_ && secure_origin_;
Wait, why are we changing the logic here?  It looks to be backwards now?

[mthiesse, 2017-04-28 19:41:31]

The CQ bit was unchecked by mthiesse@chromium.org

[mthiesse, 2017-04-28 19:42:15]

https://codereview.chromium.org/2841333003/diff/40001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2841333003/diff/40001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:188: bool enabled =
web_vr_mode_ && secure_origin_;
On 2017/04/28 19:36:50, amp wrote:
> Wait, why are we changing the logic here?  It looks to be backwards now?

oooops. For debugging, good catch.

[mthiesse, 2017-04-28 19:46:50]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-04-28 19:46:51]

The patchset sent to the CQ was uploaded after l-g-t-m from cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2841333003/#ps60001
(title: "Remove debugging code")

[commit-bot: I haz the power, 2017-04-28 19:47:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:23:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493408810877440,
"parent_rev": "bbfc047fe24d71fe097e17badc5b35534caba593", "commit_rev":
"df3332994e58f25503cf5974b50faf9625ab7435"}

[commit-bot: I haz the power, 2017-04-28 21:23:23]

Description was changed from

==========
VR: Make webVR insecure content warning look more like M58 warning.

This removes the info icon from the transient warning, and adjusts the element
sizes and font sizes to more closely align with M58.

BUG=
==========

to

==========
VR: Make webVR insecure content warning look more like M58 warning.

This removes the info icon from the transient warning, and adjusts the element
sizes and font sizes to more closely align with M58.

BUG=

Review-Url: https://codereview.chromium.org/2841333003
Cr-Commit-Position: refs/heads/master@{#468130}
Committed:
https://chromium.googlesource.com/chromium/src/+/df3332994e58f25503cf5974b50f...
==========

[commit-bot: I haz the power, 2017-04-28 21:23:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/df3332994e58f25503cf5974b50f...