Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2841273003:
Roll src\third_party\libyuv fc02cc380..54289f1bb (5 commits) (Closed)
|
Created:
3 years, 8 months ago by brucedawson Modified:
3 years, 7 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src\third_party\libyuv fc02cc380..3b583396b (4 commits)
https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b583396bf13
$ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s'
2017-04-24 fbarchard Disable CopyRow_MIPS
2017-04-18 brucedawson Avoid double compiles of libjpeg
2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389)
2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147)
Created with:
roll-dep src\third_party\libyuv
The "Avoid double compiles of libjpeg" change will slightly reduce the number of
build steps and will also avoid hundreds of duplicate symbol warnings when
linking. Details in the bug.
BUG=706627
Review-Url: https://codereview.chromium.org/2841273003
Cr-Commit-Position: refs/heads/master@{#468117}
Committed: https://chromium.googlesource.com/chromium/src/+/f976fc19b53288cc6dca4dc80a467c319701e1b2
Patch Set 1 #Patch Set 2 : Trimming one change from the roll #Messages
Total messages: 28 (17 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
brucedawson@chromium.org changed reviewers: + fbarchard@chromium.org, vigneshv@chromium.org
Is it okay to roll the latest version of libyuv into Chrome? The try bots are looking good so far. This will also fix 231 LNK4006 warnings when building cast_receiver.lib.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Ping - just wanted to make sure you saw this.
Let me know if this is okay or not. Otherwise I'll TBR land it in a few hours.
Sorry about the delay. I don't know enough about this project to say if this is ok or not. Couple of CLs i had were around android NDK builds. I don't think that is relevant to Chromium. Frank is the authority on this.
Description was changed from ========== Roll src\third_party\libyuv fc02cc380..54289f1bb (5 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..54289f... $ git log fc02cc380..54289f1bb --date=short --no-merges --format='%ad %ae %s' 2017-04-25 vigneshv Fix mips build on android ndk r14+ 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv BUG=706627 ========== to ========== Roll src\third_party\libyuv fc02cc380..3b583396b (4 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b5833... $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv BUG=706627 ==========
Per discussions with Frank I trimmed the last change from the roll.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fbarchard@google.com changed reviewers: + fbarchard@google.com
lgtm Disabling the mips function will solve a short term clang issue for all platforms/compilers/build systems. The jpeg change fixes the clang vs visual c issue for Win64.
Description was changed from ========== Roll src\third_party\libyuv fc02cc380..3b583396b (4 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b5833... $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv BUG=706627 ========== to ========== Roll src\third_party\libyuv fc02cc380..3b583396b (4 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b5833... $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv The "Avoid double compiles of libjpeg" change will slightly reduce the number of build steps and will also avoid hundreds of duplicate symbol warnings when linking. Details in the bug. BUG=706627 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/04/28 20:22:08, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. RS LGTM
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493411428616490,
"parent_rev": "cda69aa7da5a081bd6014c56cadec2902b35f10e", "commit_rev":
"f976fc19b53288cc6dca4dc80a467c319701e1b2"}
Message was sent while issue was closed.
Description was changed from ========== Roll src\third_party\libyuv fc02cc380..3b583396b (4 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b5833... $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv The "Avoid double compiles of libjpeg" change will slightly reduce the number of build steps and will also avoid hundreds of duplicate symbol warnings when linking. Details in the bug. BUG=706627 ========== to ========== Roll src\third_party\libyuv fc02cc380..3b583396b (4 commits) https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b5833... $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca4c..ce95e5d83f (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f08..da7cc8ca4c (454907:465147) Created with: roll-dep src\third_party\libyuv The "Avoid double compiles of libjpeg" change will slightly reduce the number of build steps and will also avoid hundreds of duplicate symbol warnings when linking. Details in the bug. BUG=706627 Review-Url: https://codereview.chromium.org/2841273003 Cr-Commit-Position: refs/heads/master@{#468117} Committed: https://chromium.googlesource.com/chromium/src/+/f976fc19b53288cc6dca4dc80a46... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f976fc19b53288cc6dca4dc80a46... |
