ServiceWorker: DB functions should return status code instead of boolean (3)

content/browser/service_worker/service_worker_storage.h

Index: content/browser/service_worker/service_worker_storage.h
diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h
index 974b6f743b7ef2dd0711d78a9d4f772fa4c4d568..033f3b6b5bebee70bb21c0fec9daf3a50dcac521 100644
--- a/content/browser/service_worker/service_worker_storage.h
+++ b/content/browser/service_worker/service_worker_storage.h
@@ -151,8 +151,8 @@ class CONTENT_EXPORT ServiceWorkerStorage {
       ServiceWorkerStatusCode status);
   void DidReadRegistrationForId(
       const FindRegistrationCallback& callback,
-      const ServiceWorkerDatabase::RegistrationData& registration,
-      const ResourceList& resources,
+      ServiceWorkerDatabase::RegistrationData* registration,
+      ResourceList* resources,
       ServiceWorkerStatusCode status);
   void DidGetAllRegistrations(
       const GetAllRegistrationInfosCallback& callback,
@@ -161,12 +161,15 @@ class CONTENT_EXPORT ServiceWorkerStorage {
   void DidStoreRegistration(
       const GURL& origin,
       const StatusCallback& callback,
-      bool success);
+      ServiceWorkerStatusCode status);
   void DidDeleteRegistration(
       const GURL& origin,
       const StatusCallback& callback,
       bool origin_is_deletable,
       ServiceWorkerStatusCode status);
+  void DidDatabaseOperation(

[michaeln, 2014/05/15 20:44:58]

Maybe you have in mind to use this generically named method to complete other
operations beside UpdateToActive, and to trigger the deleteAndStartOver logic in
here?

Until there are more uses of this method, might be good to name it
DidUpdateToActiveState.

[nhiroki, 2014/05/19 04:58:04]

You are right.
Okay, renamed it.

+      const StatusCallback& callback,
+      ServiceWorkerStatusCode status);
 
   scoped_refptr<ServiceWorkerRegistration> CreateRegistration(
       const ServiceWorkerDatabase::RegistrationData& data);