ServiceWorker: DB functions should return status code instead of boolean (3)

content/browser/service_worker/service_worker_storage.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_STORAGE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_STORAGE_H_
 
 #include <map>
 #include <set>
 #include <vector>
@@ skipping 133 matching lines @@
       const FindRegistrationCallback& callback,
       RegistrationList* registrations,
       ServiceWorkerStatusCode status);
   void DidGetRegistrationsForDocument(
       const GURL& scope,
       const FindRegistrationCallback& callback,
       RegistrationList* registrations,
       ServiceWorkerStatusCode status);
   void DidReadRegistrationForId(
       const FindRegistrationCallback& callback,
-      const ServiceWorkerDatabase::RegistrationData& registration,
-      const ResourceList& resources,
+      ServiceWorkerDatabase::RegistrationData* registration,
+      ResourceList* resources,
       ServiceWorkerStatusCode status);
   void DidGetAllRegistrations(
       const GetAllRegistrationInfosCallback& callback,
       RegistrationList* registrations,
       ServiceWorkerStatusCode status);
   void DidStoreRegistration(
       const GURL& origin,
       const StatusCallback& callback,
-      bool success);
+      ServiceWorkerStatusCode status);
   void DidDeleteRegistration(
       const GURL& origin,
       const StatusCallback& callback,
       bool origin_is_deletable,
       ServiceWorkerStatusCode status);
+  void DidDatabaseOperation(

[michaeln, 2014/05/15 20:44:58]

Maybe you have in mind to use this generically named method to complete other
operations beside UpdateToActive, and to trigger the deleteAndStartOver logic in
here?

Until there are more uses of this method, might be good to name it
DidUpdateToActiveState.

[nhiroki, 2014/05/19 04:58:04]

You are right.
Okay, renamed it.

+      const StatusCallback& callback,
+      ServiceWorkerStatusCode status);
 
   scoped_refptr<ServiceWorkerRegistration> CreateRegistration(
       const ServiceWorkerDatabase::RegistrationData& data);
   ServiceWorkerRegistration* FindInstallingRegistrationForDocument(
       const GURL& document_url);
   ServiceWorkerRegistration* FindInstallingRegistrationForPattern(
       const GURL& scope);
   ServiceWorkerRegistration* FindInstallingRegistrationForId(
       int64 registration_id);
 
@@ skipping 35 matching lines @@
   scoped_ptr<ServiceWorkerDiskCache> disk_cache_;
 
   base::WeakPtrFactory<ServiceWorkerStorage> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerStorage);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_STORAGE_H_