Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Issue 2841223003: [Offline Pages] Remove dependencies from particular namespaces in tests. (Closed)

Created:
3 years, 8 months ago by dewittj
Modified:
3 years, 8 months ago
Reviewers:
romax
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Remove dependencies from particular namespaces in tests. This is not always possible (for tests explicitly testing particular production namespace behavior). But some tests are just around general namespace policy behavior. BUG=705086 Review-Url: https://codereview.chromium.org/2841223003 Cr-Commit-Position: refs/heads/master@{#467524} Committed: https://chromium.googlesource.com/chromium/src/+/65f71c8b5c87a14a7b487f2897c06867282a8de8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -19 lines) Patch
M components/offline_pages/core/offline_page_model_impl_unittest.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_page_storage_manager_unittest.cc View 13 chunks +43 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dewittj
PTAL!
3 years, 8 months ago (2017-04-26 22:35:34 UTC) #2
romax
LGTM!
3 years, 8 months ago (2017-04-27 00:03:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841223003/1
3 years, 8 months ago (2017-04-27 00:04:50 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 00:12:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65f71c8b5c87a14a7b487f2897c0...

Powered by Google App Engine
This is Rietveld 408576698