Add UMA for popup overlays removed from saved MHTML page

Add UMA for popup overlays removed from saved MHTML page

BUG=715371
TEST=tests updated

Review-Url: https://codereview.chromium.org/2841223002
Cr-Commit-Position: refs/heads/master@{#468172}
Committed: https://chromium.googlesource.com/chromium/src/+/d3706ec656557d2a8077d9a941a59be933bf8ec7

[jianli, 2017-04-26 21:56:04]

jianli@chromium.org changed reviewers:
+ dimich@chromium.org, tkent@chromium.org

[jianli, 2017-04-26 22:20:39]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 22:21:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:11:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tkent, 2017-04-27 01:40:31]

lgtm

[Dmitry Titov, 2017-04-27 02:25:46]

lgtm

[jianli, 2017-04-27 20:41:01]

jianli@chromium.org changed reviewers:
+ holte@chromium.org

[jianli, 2017-04-27 20:41:01]

holte for histograms

[Steven Holte, 2017-04-27 23:39:05]

lgtm

[Steven Holte, 2017-04-27 23:41:53]

https://codereview.chromium.org/2841223002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right):

https://codereview.chromium.org/2841223002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebFrameSerializer.cpp:177:
"PageSerialization.MhtmlGeneration.PopupOverlaySkippedCount", true);
Actually the name of this histogram and how you are recording it are a bit
strange.  Count in the name implies that this histogram would be recording the
number of times this was skipped, but you are instead recording that it was
skipped.

I'd suggest changing the name to
PageSerialization.MhtmlGeneration.PopupOverlaySkipped and probably recording a
False case for a reasonable baseline.

[jianli, 2017-04-28 00:52:07]

https://codereview.chromium.org/2841223002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right):

https://codereview.chromium.org/2841223002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebFrameSerializer.cpp:177:
"PageSerialization.MhtmlGeneration.PopupOverlaySkippedCount", true);
On 2017/04/27 23:41:53, Steven Holte wrote:
> Actually the name of this histogram and how you are recording it are a bit
> strange.  Count in the name implies that this histogram would be recording the
> number of times this was skipped, but you are instead recording that it was
> skipped.
> 
> I'd suggest changing the name to
> PageSerialization.MhtmlGeneration.PopupOverlaySkipped and probably recording a
> False case for a reasonable baseline.

Done.

[Steven Holte, 2017-04-28 00:54:23]

lgtm

[jianli, 2017-04-28 07:52:48]

The CQ bit was checked by jianli@chromium.org

[jianli, 2017-04-28 07:52:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2841223002/#ps20001
(title: "Address feedback")

[commit-bot: I haz the power, 2017-04-28 07:53:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 07:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:56:17]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2017-04-28 20:53:16]

The CQ bit was checked by jianli@chromium.org

[jianli, 2017-04-28 20:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
dimich@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2841223002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-28 20:54:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:09:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493412796917570,
"parent_rev": "11b44dd3ae59e1116acc9358a1807ccdf29a1359", "commit_rev":
"d3706ec656557d2a8077d9a941a59be933bf8ec7"}

[commit-bot: I haz the power, 2017-04-28 23:09:51]

Description was changed from

==========
Add UMA for popup overlays removed from saved MHTML page

BUG=715371
TEST=tests updated
==========

to

==========
Add UMA for popup overlays removed from saved MHTML page

BUG=715371
TEST=tests updated

Review-Url: https://codereview.chromium.org/2841223002
Cr-Commit-Position: refs/heads/master@{#468172}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3706ec656557d2a8077d9a941a5...
==========

[commit-bot: I haz the power, 2017-04-28 23:09:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d3706ec656557d2a8077d9a941a5...