chrome/android/java/strings/android_chrome_strings.grd - Issue 2841193002: Implement privacy disclosure for an unbound webapk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)

Patch Set: Implement privacy disclosure for an unbound webapk. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index 4caca00c5c4b70b77af82b38905cd0a02768d656..404bd2cf09d466ed2d5d48130e7e7c89b02c1116 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -2853,16 +2853,8 @@ You must have Bluetooth and Location turned on in order to use the Physical Web.

</message>

- <message name="IDS_WEBAPK_UNKNOWN_SOURCES_DIALOG_TITLE" desc="Title of dialog warning user that installation from Unknown sources is required for WebAPK experiment.">

awdf 2017/05/02 12:33:35 are these 3 strings now unused then?

pkotwicz 2017/05/02 17:03:09 Yes these strings are now unused. Yaron can you pl

- Improved Add to Home screen Experiment

- </message>

- <message name="IDS_WEBAPK_UNKNOWN_SOURCES_DIALOG_MESSAGE" desc="Text of dialog warning user that installation from Unknown sources is required for WebAPK experiment">

- Turn on “Unknown sources” in Android security settings to try "Improved Add to Home screen" experiment. Be sure to disable this setting when you’re done trying it out.

- </message>

- <message name="IDS_WEBAPK_UNKNOWN_SOURCES_SETTINGS_BUTTON" desc="Button label for opening Android Settings from dialog warning user that installation from Unknown sources is required for WebAPK experiment.">

- Settings

+ <message name="IDS_WEBAPK_DISCLOSURE_NOTIFICATION" desc="Message on the notification that indicates a WebApk may use Chrome data.">

+ This app may share information with your browser, like cookies or login credentials.

</message>