Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2687973005: Remove "Turn on unknown sources dialog" (Closed)

Created:
3 years, 10 months ago by pkotwicz
Modified:
3 years, 10 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "Turn on unknown sources dialog" The logic to show the dialog is finicky and has often regressed. It regressed most recently due to https://codereview.chromium.org/2675803004 BUG=690752 Review-Url: https://codereview.chromium.org/2687973005 Cr-Commit-Position: refs/heads/master@{#450117} Committed: https://chromium.googlesource.com/chromium/src/+/b2ab13f951d39a8bcc1fda7547ed05ffbdf56e64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 3 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
pkotwicz
Dominick, can you please take a look?
3 years, 10 months ago (2017-02-11 02:50:54 UTC) #3
dominickn
On 2017/02/11 02:50:54, pkotwicz wrote: > Dominick, can you please take a look? Should the ...
3 years, 10 months ago (2017-02-12 23:03:55 UTC) #8
pkotwicz
The unknown sources installation path is still useful. I use it for testing. We haven't ...
3 years, 10 months ago (2017-02-13 18:01:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687973005/1
3 years, 10 months ago (2017-02-13 18:54:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/362967)
3 years, 10 months ago (2017-02-13 19:03:09 UTC) #13
pkotwicz
dfalcantara@ for ChromeTabbedActivity.java change
3 years, 10 months ago (2017-02-13 22:07:16 UTC) #15
gone
lgtm
3 years, 10 months ago (2017-02-13 22:08:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687973005/1
3 years, 10 months ago (2017-02-13 22:10:18 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 22:22:53 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2ab13f951d39a8bcc1fda7547ed...

Powered by Google App Engine
This is Rietveld 408576698