Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2841173002: Add presubmit check against usage of BrowserThread::GetBlockingPool(). (Closed)
Patch Set: CR-gab Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 9d29982a0432e03586182154df67edb05ade4327..ffde9bd713be4b13fde57e912df90b8492cbd4ee 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -319,6 +319,16 @@ _BANNED_CPP_FUNCTIONS = (
True,
(),
),
+ (
+ 'BrowserThread::GetBlockingPool',
+ (
+ 'Use base/task_scheduler/post_task.h instead of the blocking pool. See',
+ 'mapping between both APIs in content/public/browser/browser_thread.h.',
+ 'For questions, reach out to base/task_scheduler/OWNERS.',
robliao 2017/05/01 18:03:01 Nit: s/reach out to/contact/
fdoray 2017/05/01 18:05:22 Done.
+ ),
+ True,
+ (),
+ ),
)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698