Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: PRESUBMIT.py

Issue 2841173002: Add presubmit check against usage of BrowserThread::GetBlockingPool(). (Closed)
Patch Set: CR-gab Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 ), 312 ),
313 ), 313 ),
314 ( 314 (
315 '#pragma comment(lib,', 315 '#pragma comment(lib,',
316 ( 316 (
317 'Specify libraries to link with in build files and not in the source.', 317 'Specify libraries to link with in build files and not in the source.',
318 ), 318 ),
319 True, 319 True,
320 (), 320 (),
321 ), 321 ),
322 (
323 'BrowserThread::GetBlockingPool',
324 (
325 'Use base/task_scheduler/post_task.h instead of the blocking pool. See',
326 'mapping between both APIs in content/public/browser/browser_thread.h.',
327 'For questions, reach out to base/task_scheduler/OWNERS.',
robliao 2017/05/01 18:03:01 Nit: s/reach out to/contact/
fdoray 2017/05/01 18:05:22 Done.
328 ),
329 True,
330 (),
331 ),
322 ) 332 )
323 333
324 334
325 _IPC_ENUM_TRAITS_DEPRECATED = ( 335 _IPC_ENUM_TRAITS_DEPRECATED = (
326 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' 336 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n'
327 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc') 337 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc')
328 338
329 339
330 _VALID_OS_MACROS = ( 340 _VALID_OS_MACROS = (
331 # Please keep sorted. 341 # Please keep sorted.
(...skipping 2122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2454 output_api, 2464 output_api,
2455 json_url='http://chromium-status.appspot.com/current?format=json')) 2465 json_url='http://chromium-status.appspot.com/current?format=json'))
2456 2466
2457 results.extend( 2467 results.extend(
2458 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2468 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2459 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2469 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2460 input_api, output_api)) 2470 input_api, output_api))
2461 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2471 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2462 input_api, output_api)) 2472 input_api, output_api))
2463 return results 2473 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698