Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2841153002: Relocate GC::DrawLineForDocumentMarker() (Closed)

Created:
3 years, 7 months ago by f(malita)
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews-paint_chromium.org, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relocate GC::DrawLineForDocumentMarker() DrawLineForDocumentMarker() only has one client (InlineTextBoxPainter), so it makes sense for it to be a private helper. Then we can also remove the DocumentMarkerLineStyle GC enum. BUG=424655 R=schenney@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841153002 Cr-Commit-Position: refs/heads/master@{#467656} Committed: https://chromium.googlesource.com/chromium/src/+/6e1342b6185184afba16d2ae316680935ec6130c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -157 lines) Patch
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 3 chunks +134 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +0 lines, -133 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
3 years, 7 months ago (2017-04-27 12:33:45 UTC) #6
Stephen Chennney
Enthusiastic lgtm.
3 years, 7 months ago (2017-04-27 13:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841153002/1
3 years, 7 months ago (2017-04-27 13:18:33 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 13:24:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e1342b6185184afba16d2ae3166...

Powered by Google App Engine
This is Rietveld 408576698