Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Issue 2841103002: Chromad: Add GetUserStatus call into AuthPolicyClient (Closed)

Created:
3 years, 8 months ago by Roman Sorokin (ftl)
Modified:
3 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromad: Add GetUserStatus call into AuthPolicyClient Also s/ActiveDirectoryAccountData/ActiveDirectoryAccountInfo BUG=662400 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2841103002 Cr-Commit-Position: refs/heads/master@{#467967} Committed: https://chromium.googlesource.com/chromium/src/+/01014b7ca4112940ca3080729beba9701321620e

Patch Set 1 #

Patch Set 2 : Fix test build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -39 lines) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/auth_policy_client.h View 3 chunks +11 lines, -4 lines 0 comments Download
M chromeos/dbus/auth_policy_client.cc View 3 chunks +42 lines, -15 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/login/auth/authpolicy_login_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/authpolicy_login_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
Roman Sorokin (ftl)
Hey Hashimoto, please take a look at chromeos/dbus/*. Thanks!
3 years, 8 months ago (2017-04-26 16:50:38 UTC) #2
hashimoto
Sorry for being late to respond. lgtm
3 years, 7 months ago (2017-04-28 06:06:35 UTC) #3
Roman Sorokin (ftl)
On 2017/04/28 06:06:35, hashimoto wrote: > Sorry for being late to respond. > lgtm No ...
3 years, 7 months ago (2017-04-28 09:13:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841103002/1
3 years, 7 months ago (2017-04-28 09:13:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/372611)
3 years, 7 months ago (2017-04-28 09:51:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841103002/20001
3 years, 7 months ago (2017-04-28 11:02:25 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 12:26:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01014b7ca4112940ca3080729beb...

Powered by Google App Engine
This is Rietveld 408576698