Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: src/inspector/injected-script.cc

Issue 2841053002: [inspector] Add some context scopes to inspector code (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-function-call.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/injected-script.cc
diff --git a/src/inspector/injected-script.cc b/src/inspector/injected-script.cc
index b4183a735a250f8d0493050df0401404626b51a1..183fa446b35d9b821b0ba24cb0776cb16b6a8bd1 100644
--- a/src/inspector/injected-script.cc
+++ b/src/inspector/injected-script.cc
@@ -175,6 +175,7 @@ Response InjectedScript::wrapObject(
v8::HandleScope handles(m_context->isolate());
v8::Local<v8::Value> wrappedObject;
v8::Local<v8::Context> context = m_context->context();
+ v8::Context::Scope contextScope(context);
dgozman 2017/04/26 15:52:49 I don't think this is needed. It calls into wrapVa
Jens Widell 2017/04/26 15:57:13 Indeed. I now wonder how come I ended up adding th
Response response = wrapValue(value, groupName, forceValueType,
generatePreview, &wrappedObject);
if (!response.isSuccess()) return response;
« no previous file with comments | « no previous file | src/inspector/v8-function-call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698