[inspector] Add some context scopes to inspector code

src/inspector/injected-script.cc

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 157 matching lines @@
   m_native->unbind(boundId);
 }
 
 Response InjectedScript::wrapObject(
     v8::Local<v8::Value> value, const String16& groupName, bool forceValueType,
     bool generatePreview,
     std::unique_ptr<protocol::Runtime::RemoteObject>* result) const {
   v8::HandleScope handles(m_context->isolate());
   v8::Local<v8::Value> wrappedObject;
   v8::Local<v8::Context> context = m_context->context();
+  v8::Context::Scope contextScope(context);

[dgozman, 2017/04/26 15:52:49]

I don't think this is needed. It calls into wrapValue, which calls into
V8FunctionCall.

Overall, I think it only makes sense to enter context before accessing V8 api.
WDYT?

[Jens Widell, 2017/04/26 15:57:13]

Indeed. I now wonder how come I ended up adding this one. I'll test without it
to make sure there wasn't a reason, then drop.
Yes, absolutely. Only reason to cover more code than just V8 API usage would be
if it avoided adding context scopes all over the place, by putting them in
logical central locations. But that's not at all the case here.

   Response response = wrapValue(value, groupName, forceValueType,
                                 generatePreview, &wrappedObject);
   if (!response.isSuccess()) return response;
   protocol::ErrorSupport errors;
   std::unique_ptr<protocol::Value> protocolValue;
   response = toProtocolValue(context, wrappedObject, &protocolValue);
   if (!response.isSuccess()) return response;
 
   *result =
       protocol::Runtime::RemoteObject::fromValue(protocolValue.get(), &errors);
@@ skipping 348 matching lines @@
 Response InjectedScript::CallFrameScope::findInjectedScript(
     V8InspectorSessionImpl* session) {
   std::unique_ptr<RemoteCallFrameId> remoteId;
   Response response = RemoteCallFrameId::parse(m_remoteCallFrameId, &remoteId);
   if (!response.isSuccess()) return response;
   m_frameOrdinal = static_cast<size_t>(remoteId->frameOrdinal());
   return session->findInjectedScript(remoteId.get(), m_injectedScript);
 }
 
 }  // namespace v8_inspector