chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index 1f895c62f8a21315a86920f64250c82031776b63..093a44fe015985e10d97ef3329a2e63b85b59a5c 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -163,7 +163,10 @@ class EphemeralAppBrowserTest : public PlatformAppBrowserTest {

ExtensionService* service =

ExtensionSystem::Get(browser()->profile())->extension_service();

ASSERT_TRUE(service);

- service->UninstallExtension(app_id, false, NULL);

+ service->UninstallExtension(

+ app_id,

+ ExtensionService::kUninstallReasonOrphanedEphemeralExtension,

+ NULL);

uninstalled_signal.Wait();

}

« no previous file with comments | « no previous file | chrome/browser/apps/ephemeral_app_service.cc » ('j') | chrome/browser/extensions/api/management/management_api.cc » ('J')