Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chrome/browser/search/hotword_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/hotword_service.cc
diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc
index f7f8aeddb8ebf2d4bf0b360ea86f9d669160dc1f..f395fd9d15584130a0db51e7aab44e57de5cdc70 100644
--- a/chrome/browser/search/hotword_service.cc
+++ b/chrome/browser/search/hotword_service.cc
@@ -360,7 +360,9 @@ bool HotwordService::UninstallHotwordExtension(
ExtensionService* extension_service) {
base::string16 error;
if (!extension_service->UninstallExtension(
- extension_misc::kHotwordExtensionId, true, &error)) {
+ extension_misc::kHotwordExtensionId,
+ ExtensionService::UNINSTALL_REASON_INTERNAL_MANAGEMENT,
+ &error)) {
LOG(WARNING) << "Cannot uninstall extension with id "
<< extension_misc::kHotwordExtensionId
<< ": " << error;
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/sync/test/integration/sync_extension_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698