chrome/browser/policy/policy_browsertest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index e83e981f76ec2610cbf3af28510fea87ca16431e..a608049f4612674d9f570d870bc3931fd495a546 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -705,7 +705,8 @@ class PolicyTest : public InProcessBrowserTest {

expect_success ? chrome::NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED

: chrome::NOTIFICATION_EXTENSION_UNINSTALL_NOT_ALLOWED,

content::NotificationService::AllSources());

- extension_service()->UninstallExtension(id, false, NULL);

+ extension_service()->UninstallExtension(

+ id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

observer.Wait();

}

« no previous file with comments | « chrome/browser/extensions/shared_module_service_unittest.cc ('k') | chrome/browser/search/hotword_service.cc » ('j') | no next file with comments »