Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 5f5fe6b4f061c0c9229e89555289a030e82e6fa3..33c5196f6746336376034357092ad4b363cf1ff2 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -794,8 +794,10 @@ void AppLauncherHandler::ExtensionUninstallAccepted() {
if (!extension)
return;
- extension_service_->UninstallExtension(extension_id_prompting_,
- false /* external_uninstall */, NULL);
+ extension_service_->UninstallExtension(
+ extension_id_prompting_,
+ ExtensionService::UNINSTALL_REASON_USER_INITIATED,
+ NULL);
CleanupAfterUninstall();
}

Powered by Google App Engine
This is Rietveld 408576698