chrome/browser/extensions/shared_module_service_unittest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_module_service_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review feedback. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.h ('K') | « chrome/browser/extensions/shared_module_service.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | chrome/browser/search/hotword_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/shared_module_service_unittest.cc

diff --git a/chrome/browser/extensions/shared_module_service_unittest.cc b/chrome/browser/extensions/shared_module_service_unittest.cc

index 2c38444c3f0fdc05faa559f5c839d71bd0b61aef..4cc872be718a077b39bad9451c80a04aae0f078e 100644

--- a/chrome/browser/extensions/shared_module_service_unittest.cc

+++ b/chrome/browser/extensions/shared_module_service_unittest.cc

@@ -131,7 +131,7 @@ TEST_F(SharedModuleServiceUnitTest, PruneSharedModulesOnUninstall) {

// Uninstall the extension that imports our module.

base::string16 error;

service_->UninstallExtension(importing_extension->id(),

- false, // Not external uninstall.

+ ExtensionService::UNINSTALL_REASON_DEFAULT,

&error);

EXPECT_TRUE(error.empty());