Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Issue 2840993003: [headless] Expose DevToolsTarget via HeadlessBrowser + add tracing test. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Expose DevToolsTarget via HeadlessBrowser + add tracing test. BUG=546953 Review-Url: https://codereview.chromium.org/2840993003 Cr-Commit-Position: refs/heads/master@{#468229} Committed: https://chromium.googlesource.com/chromium/src/+/32fdf2ad9ef36269d8c5369c4ce667a80c50d0d9

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
M headless/lib/browser/headless_browser_impl.h View 3 chunks +11 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 5 chunks +37 lines, -0 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 2 2 chunks +73 lines, -0 lines 0 comments Download
M headless/public/headless_browser.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Eric Seckler
3 years, 8 months ago (2017-04-26 10:21:28 UTC) #4
Sami
lgtm, thanks! https://codereview.chromium.org/2840993003/diff/1/headless/public/headless_browser.h File headless/public/headless_browser.h (right): https://codereview.chromium.org/2840993003/diff/1/headless/public/headless_browser.h#newcode49 headless/public/headless_browser.h:49: // Return a DevTools target corresponding to ...
3 years, 8 months ago (2017-04-26 15:47:06 UTC) #7
Eric Seckler
Thanks! https://codereview.chromium.org/2840993003/diff/1/headless/public/headless_browser.h File headless/public/headless_browser.h (right): https://codereview.chromium.org/2840993003/diff/1/headless/public/headless_browser.h#newcode49 headless/public/headless_browser.h:49: // Return a DevTools target corresponding to this ...
3 years, 7 months ago (2017-04-27 09:14:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840993003/20001
3 years, 7 months ago (2017-04-27 09:14:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/356122) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-04-27 09:17:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840993003/40001
3 years, 7 months ago (2017-04-29 06:38:08 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 07:08:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/32fdf2ad9ef36269d8c5369c4ce6...

Powered by Google App Engine
This is Rietveld 408576698