Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2840993002: Revert of Implementation of a full screen app list and re-alphabetized switches (Closed)

Created:
3 years, 8 months ago by vadimt
Modified:
3 years, 8 months ago
Reviewers:
sky, newcomer
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implementation of a full screen app list and re-alphabetized switches (patchset #11 id:440001 of https://codereview.chromium.org/2802903003/ ) Reason for revert: Suspecting that this breaks ash_unittests Original issue's description: > Implementation of a full screen app list behind a switch (as opposed to a feature flag). > > Also re-alphabetized switches in ash_switches.cc > > BUG=711349 > > Review-Url: https://codereview.chromium.org/2802903003 > Cr-Commit-Position: refs/heads/master@{#467088} > Committed: https://chromium.googlesource.com/chromium/src/+/23bdfdaf36a0e72e57e6bcf909d87fd4f5d5c663 TBR=sky@chromium.org,newcomer@chromium.org,newcomer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711349 Review-Url: https://codereview.chromium.org/2840993002 Cr-Commit-Position: refs/heads/master@{#467181} Committed: https://chromium.googlesource.com/chromium/src/+/36544f37e39f0852922a83164f2b0a13c3431086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -149 lines) Patch
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate_unittest.cc View 7 chunks +4 lines, -26 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M testing/buildbot/filters/ash_mus_unittests.filter View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/app_list/app_list_switches.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/app_list/demo/app_list_demo_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.h View 4 chunks +6 lines, -15 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 11 chunks +40 lines, -69 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vadimt
Created Revert of Implementation of a full screen app list and re-alphabetized switches
3 years, 8 months ago (2017-04-26 00:36:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840993002/1
3 years, 8 months ago (2017-04-26 00:36:47 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 00:38:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36544f37e39f0852922a83164f2b...

Powered by Google App Engine
This is Rietveld 408576698