Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2840983002: Fixes -Wsometimes-uninitialized introduced in r70d2a00. (Closed)

Created:
3 years, 8 months ago by alokp
Modified:
3 years, 8 months ago
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes -Wsometimes-uninitialized introduced in r70d2a00. BUG=663503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
alokp
3 years, 8 months ago (2017-04-25 23:28:54 UTC) #4
slan
lgtm
3 years, 8 months ago (2017-04-25 23:37:08 UTC) #6
tguilbert
On 2017/04/25 23:37:08, slan wrote: > lgtm Ah, sorry! I did not have ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION enabled. ...
3 years, 8 months ago (2017-04-25 23:59:08 UTC) #7
tguilbert
On 2017/04/25 23:59:08, tguilbert wrote: > On 2017/04/25 23:37:08, slan wrote: > > lgtm > ...
3 years, 8 months ago (2017-04-26 00:23:52 UTC) #8
slan
Tom, thanks for updating it! Do you think that your CL (crrev.com/2769153005) will land in ...
3 years, 8 months ago (2017-04-26 00:47:36 UTC) #9
tguilbert
On 2017/04/26 00:47:36, slan wrote: > Tom, thanks for updating it! Do you think that ...
3 years, 8 months ago (2017-04-26 00:59:23 UTC) #12
ncarter (slow)
lgtm
3 years, 8 months ago (2017-04-26 19:16:00 UTC) #13
tguilbert
On 2017/04/26 19:16:00, ncarter wrote: > lgtm The patch from the other CL has landed ...
3 years, 8 months ago (2017-04-26 20:34:58 UTC) #14
alokp
3 years, 8 months ago (2017-04-26 20:36:46 UTC) #15
On 2017/04/26 20:34:58, tguilbert wrote:
> On 2017/04/26 19:16:00, ncarter wrote:
> > lgtm
> 
> The patch from the other CL has landed :)
>
https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d9625...

Thanks! I will abandon this patch.

Powered by Google App Engine
This is Rietveld 408576698