|
|
DescriptionFixes -Wsometimes-uninitialized introduced in r70d2a00.
BUG=663503
Patch Set 1 #
Messages
Total messages: 15 (6 generated)
The CQ bit was checked by alokp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alokp@chromium.org changed reviewers: + nick@chromium.org, tguilbert@chromium.org
slan@chromium.org changed reviewers: + slan@chromium.org
lgtm
On 2017/04/25 23:37:08, slan wrote: > lgtm Ah, sorry! I did not have ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION enabled. I could also fix the issue as part of this CL, on which ncarter is already a reviewer: https://codereview.chromium.org/2769153005/diff/60001/content/renderer/render... FYI, this extra field will be completely fixed/removed in the following CL: https://codereview.chromium.org/2822353003/diff/40001/content/renderer/render... (But there are still two intermediary CLs that I need to land in the mean time).
On 2017/04/25 23:59:08, tguilbert wrote: > On 2017/04/25 23:37:08, slan wrote: > > lgtm > > Ah, sorry! I did not have ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION enabled. > > I could also fix the issue as part of this CL, on which ncarter is already a > reviewer: > https://codereview.chromium.org/2769153005/diff/60001/content/renderer/render... > > > FYI, this extra field will be completely fixed/removed in the following CL: > https://codereview.chromium.org/2822353003/diff/40001/content/renderer/render... > (But there are still two intermediary CLs that I need to land in the mean time). I have updated this CL to incorporate your fix, which should cover the ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION case. https://codereview.chromium.org/2769153005/
Tom, thanks for updating it! Do you think that your CL (crrev.com/2769153005) will land in the near future? The Cast team's internal roll is blocked on this issue, so we'd like to get it cleaned up fast. If your CL will land tomorrow, then incorporating this change there SGTM. Thanks for helping us out! On Tue, Apr 25, 2017 at 5:23 PM, <tguilbert@chromium.org> wrote: > On 2017/04/25 23:59:08, tguilbert wrote: > > On 2017/04/25 23:37:08, slan wrote: > > > lgtm > > > > Ah, sorry! I did not have ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION > enabled. > > > > I could also fix the issue as part of this CL, on which ncarter is > already a > > reviewer: > > > https://codereview.chromium.org/2769153005/diff/60001/ > content/renderer/render_frame_impl.cc > > > > > > FYI, this extra field will be completely fixed/removed in the following > CL: > > > https://codereview.chromium.org/2822353003/diff/40001/ > content/renderer/render_frame_impl.cc > > (But there are still two intermediary CLs that I need to land in the mean > time). > > I have updated this CL to incorporate your fix, which should cover the > ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION case. > https://codereview.chromium.org/2769153005/ > > https://codereview.chromium.org/2840983002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/26 00:47:36, slan wrote: > Tom, thanks for updating it! Do you think that your CL (crrev.com/2769153005) > will land in the near future? The Cast team's internal roll is blocked on > this issue, so we'd like to get it cleaned up fast. If your CL will land > tomorrow, then incorporating this change there SGTM. Thanks for helping us > out! > > On Tue, Apr 25, 2017 at 5:23 PM, <mailto:tguilbert@chromium.org> wrote: > > > On 2017/04/25 23:59:08, tguilbert wrote: > > > On 2017/04/25 23:37:08, slan wrote: > > > > lgtm > > > > > > Ah, sorry! I did not have ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION > > enabled. > > > > > > I could also fix the issue as part of this CL, on which ncarter is > > already a > > > reviewer: > > > > > https://codereview.chromium.org/2769153005/diff/60001/ > > content/renderer/render_frame_impl.cc > > > > > > > > > FYI, this extra field will be completely fixed/removed in the following > > CL: > > > > > https://codereview.chromium.org/2822353003/diff/40001/ > > content/renderer/render_frame_impl.cc > > > (But there are still two intermediary CLs that I need to land in the mean > > time). > > > > I have updated this CL to incorporate your fix, which should cover the > > ENABLE_RUNTIME_MEDIA_RENDERER_SELECTION case. > > https://codereview.chromium.org/2769153005/ > > > > https://codereview.chromium.org/2840983002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. Yes, I will make sure it lands tomorrow!
lgtm
On 2017/04/26 19:16:00, ncarter wrote: > lgtm The patch from the other CL has landed :) https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d9625...
On 2017/04/26 20:34:58, tguilbert wrote: > On 2017/04/26 19:16:00, ncarter wrote: > > lgtm > > The patch from the other CL has landed :) > https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d9625... Thanks! I will abandon this patch. |