CSS Motion Path: delete implementation of motion-rotation property

CSS Motion Path: delete implementation of motion-rotation property

The 'motion-rotation' property has been replaced by 'offset-rotate'.

'motion-rotation' is among the properties disabled in M58.

BUG=711937
Review-Url: https://codereview.chromium.org/2840943003
Cr-Commit-Position: refs/heads/master@{#467952}
Committed: https://chromium.googlesource.com/chromium/src/+/9274fd6bfe4e948608f1b830d630438a077cef3d

[Eric Willigers, 2017-04-27 01:41:41]

ericwilligers@chromium.org changed reviewers:
+ bugsnash@chromium.org

[Bugs Nash, 2017-04-27 06:23:28]

On 2017/04/27 at 01:41:41, ericwilligers wrote:
> 

lgtm with following changes

- change motion-rotation to offset-rotation in
/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
- rename the layout test css3/motion-path/motion-rotation-overflow-crash.html,
perhaps to rotation-overflow-crash

[Eric Willigers, 2017-04-27 07:23:17]

On 2017/04/27 06:23:28, Bugs Nash wrote:
> On 2017/04/27 at 01:41:41, ericwilligers wrote:
> > 
> 
> lgtm with following changes
> 
> - change motion-rotation to offset-rotation in
> /Source/core/paint/PaintPropertyTreeBuilderTest.cpp

I don't see motion-rotation in PaintPropertyTreeBuilderTest.cpp

> - rename the layout test css3/motion-path/motion-rotation-overflow-crash.html,
> perhaps to rotation-overflow-crash

Done

[Eric Willigers, 2017-04-27 07:23:24]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-04-27 07:23:41]

ericwilligers@chromium.org changed reviewers:
+ meade@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:23:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 09:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:14:03]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-04-27 22:33:32]

On 2017/04/27 at 07:23:17, ericwilligers wrote:
> On 2017/04/27 06:23:28, Bugs Nash wrote:
> > On 2017/04/27 at 01:41:41, ericwilligers wrote:
> > > 
> > 
> > lgtm with following changes
> > 
> > - change motion-rotation to offset-rotation in
> > /Source/core/paint/PaintPropertyTreeBuilderTest.cpp
> 
> I don't see motion-rotation in PaintPropertyTreeBuilderTest.cpp
> 

Oh, never mind, you changed it already in the other patch. Maybe that one hadn't
landed when I did my last review? 


> > - rename the layout test
css3/motion-path/motion-rotation-overflow-crash.html,
> > perhaps to rotation-overflow-crash
> 
> Done

[meade_UTC10, 2017-04-28 07:45:49]

lgtm

[Eric Willigers, 2017-04-28 08:47:12]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-04-28 08:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2840943003/#ps20001
(title: "rename")

[commit-bot: I haz the power, 2017-04-28 08:47:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 10:25:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493369232926710,
"parent_rev": "6273712b527b4e13ec0d854fcd11e0b5e034eb2a", "commit_rev":
"9274fd6bfe4e948608f1b830d630438a077cef3d"}

[commit-bot: I haz the power, 2017-04-28 10:25:28]

Description was changed from

==========
CSS Motion Path: delete implementation of motion-rotation property

The 'motion-rotation' property has been replaced by 'offset-rotate'.

'motion-rotation' is among the properties disabled in M58.

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of motion-rotation property

The 'motion-rotation' property has been replaced by 'offset-rotate'.

'motion-rotation' is among the properties disabled in M58.

BUG=711937

Review-Url: https://codereview.chromium.org/2840943003
Cr-Commit-Position: refs/heads/master@{#467952}
Committed:
https://chromium.googlesource.com/chromium/src/+/9274fd6bfe4e948608f1b830d630...
==========

[commit-bot: I haz the power, 2017-04-28 10:25:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9274fd6bfe4e948608f1b830d630...