Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2840943002: Update DEBUG_AUDIONODE_REFERENCES to new coding style (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DEBUG_AUDIONODE_REFERENCES to new coding style This makes building with DEBUG_AUDIONODE_REFERENCES work again when set. BUG=715251 TEST= Review-Url: https://codereview.chromium.org/2840943002 Cr-Commit-Position: refs/heads/master@{#467333} Committed: https://chromium.googlesource.com/chromium/src/+/16c4014dbbb86eb359e0d827e70ce264f60f83f1

Patch Set 1 #

Patch Set 2 : Turn off flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 8 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-25 20:30:30 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-04-25 20:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840943002/20001
3 years, 8 months ago (2017-04-26 14:56:51 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 15:53:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16c4014dbbb86eb359e0d827e70c...

Powered by Google App Engine
This is Rietveld 408576698