Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

The follows the same pattern created for chrome activity test rules and test base, 
where test rules and test bases share as much same implementation as possible in
the test common classes during the migration. For more on JUnit4 migration, please
check src/testing/android/docs/junit4.md

BUG=640116
Review-Url: https://codereview.chromium.org/2840933004
Cr-Commit-Position: refs/heads/master@{#468154}
Committed: https://chromium.googlesource.com/chromium/src/+/84e709061ba54e6904183c31c51e20d641586099

[the real yoland, 2017-04-26 18:49:15]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:49:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[the real yoland, 2017-04-26 18:49:58]

yolandyan@chromium.org changed reviewers:
+ dtrainor@chromium.org, jbudorick@chromium.org, mikecase@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:43:43]

Dry run: This issue passed the CQ dry run.

[mikecase (-- gone --), 2017-04-26 21:39:54]

This all lgtm!

https://codereview.chromium.org/2840933004/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestCommon.java
(right):

https://codereview.chromium.org/2840933004/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestCommon.java:25:
final class ChromeTabbedActivityTestCommon {
nit: I would consider putting some note/TODO like...

TODO(): Remove this class once all tests have been migrated to JUnit4. Move
implementations to test rule thing.

[the real yoland, 2017-04-26 22:05:01]

https://codereview.chromium.org/2840933004/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestCommon.java
(right):

https://codereview.chromium.org/2840933004/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeTabbedActivityTestCommon.java:25:
final class ChromeTabbedActivityTestCommon {
On 2017/04/26 at 21:39:53, mikecase wrote:
> nit: I would consider putting some note/TODO like...
> 
> TODO(): Remove this class once all tests have been migrated to JUnit4. Move
implementations to test rule thing.

Done

[the real yoland, 2017-04-26 22:06:09]

Description was changed from

==========
Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

BUG=640116
==========

to

==========
Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

The follows the same pattern created for chrome activity test rules and test
base, 
where test rules and test bases share as much same implementation as possible in
the test common classes during the migration. For more on JUnit4 migration,
please
check src/testing/android/docs/junit4.md

BUG=640116
==========

[the real yoland, 2017-04-28 17:31:18]

The CQ bit was checked by yolandyan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:32:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-28 17:38:49]

lgtm

[commit-bot: I haz the power, 2017-04-28 18:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 18:51:11]

Dry run: This issue passed the CQ dry run.

[the real yoland, 2017-04-28 22:09:55]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2017-04-28 22:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2840933004/#ps20001
(title: "add TODO")

[commit-bot: I haz the power, 2017-04-28 22:10:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:18:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493417395850920,
"parent_rev": "28867910b5b95627028a0f1c6a60f3982f7a5e83", "commit_rev":
"84e709061ba54e6904183c31c51e20d641586099"}

[commit-bot: I haz the power, 2017-04-28 22:18:20]

Description was changed from

==========
Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

The follows the same pattern created for chrome activity test rules and test
base, 
where test rules and test bases share as much same implementation as possible in
the test common classes during the migration. For more on JUnit4 migration,
please
check src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Add ChromeTabbedActivityTestRules for JUnit4 instrumentation tests

The follows the same pattern created for chrome activity test rules and test
base, 
where test rules and test bases share as much same implementation as possible in
the test common classes during the migration. For more on JUnit4 migration,
please
check src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2840933004
Cr-Commit-Position: refs/heads/master@{#468154}
Committed:
https://chromium.googlesource.com/chromium/src/+/84e709061ba54e6904183c31c51e...
==========

[commit-bot: I haz the power, 2017-04-28 22:18:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84e709061ba54e6904183c31c51e...