Issue 2840883003: Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2840883003: Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE]

Created:
3 years, 8 months ago by wjmaclean

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, jam, cc-bugs_chromium.org, darin-cc_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE] This CL is a demonstration of how a failure in updating an animation (i.e. marking the update as successful even when the curve duration does not change) might possibly be counteracted. A proper fix is probably more complicated, but this demonstrates the problem. This CL fixes the failure mode observed in SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest when that test is run with scroll animations enabled. BUG=710513 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -5 lines)			Patch
M	cc/animation/scroll_offset_animations_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_impl.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	content/browser/site_per_process_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2385743002 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wjmaclean

3 years, 8 months ago (2017-04-25 20:10:44 UTC) #1

Description was changed from

==========
Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE]

This CL is a demonstration of how a failure in updating an animation
(i.e. marking the update as successful even when the curve duration
does not change) might possibly be counteracted. A proper fix is
probably more complicated, but this demonstrates the problem.

This CL fixes the failure mode observed in
SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest when that test
is run with scroll animations enabled.

BUG=710513
==========

to

==========
Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE]

This CL is a demonstration of how a failure in updating an animation
(i.e. marking the update as successful even when the curve duration
does not change) might possibly be counteracted. A proper fix is
probably more complicated, but this demonstrates the problem.

This CL fixes the failure mode observed in
SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest when that test
is run with scroll animations enabled.

BUG=710513
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages