Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 2840883003: Experimental fix for scroll animation update bug. [DO NOT COMMIT THIS CHANGE]
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 // Scroll the parent frame downward. 1197 // Scroll the parent frame downward.
1198 blink::WebMouseWheelEvent scroll_event( 1198 blink::WebMouseWheelEvent scroll_event(
1199 blink::WebInputEvent::kMouseWheel, blink::WebInputEvent::kNoModifiers, 1199 blink::WebInputEvent::kMouseWheel, blink::WebInputEvent::kNoModifiers,
1200 blink::WebInputEvent::kTimeStampForTesting); 1200 blink::WebInputEvent::kTimeStampForTesting);
1201 scroll_event.SetPositionInWidget(1, 1); 1201 scroll_event.SetPositionInWidget(1, 1);
1202 scroll_event.delta_x = 0.0f; 1202 scroll_event.delta_x = 0.0f;
1203 scroll_event.delta_y = -5.0f; 1203 scroll_event.delta_y = -5.0f;
1204 // Set has_precise_scroll_deltas to keep these events off the animated scroll 1204 // Set has_precise_scroll_deltas to keep these events off the animated scroll
1205 // pathways, which currently break this test. 1205 // pathways, which currently break this test.
1206 // https://bugs.chromium.org/p/chromium/issues/detail?id=710513 1206 // https://bugs.chromium.org/p/chromium/issues/detail?id=710513
1207 scroll_event.has_precise_scrolling_deltas = true;
1208 rwhv_parent->ProcessMouseWheelEvent(scroll_event, ui::LatencyInfo()); 1207 rwhv_parent->ProcessMouseWheelEvent(scroll_event, ui::LatencyInfo());
1209 1208
1210 // Ensure that the view position is propagated to the child properly. 1209 // Ensure that the view position is propagated to the child properly.
1211 filter->Wait(); 1210 filter->Wait();
1212 update_rect = filter->last_rect(); 1211 update_rect = filter->last_rect();
1213 EXPECT_LT(update_rect.y(), initial_y); 1212 EXPECT_LT(update_rect.y(), initial_y);
1214 filter->Reset(); 1213 filter->Reset();
1215 ack_observer->Reset(); 1214 ack_observer->Reset();
1216 1215
1217 // Now scroll the nested frame upward, which should bubble to the parent. 1216 // Now scroll the nested frame upward, which should bubble to the parent.
(...skipping 8775 matching lines...) Expand 10 before | Expand all | Expand 10 after
9993 names.insert(root->children[0]->frame_entry->frame_unique_name()); 9992 names.insert(root->children[0]->frame_entry->frame_unique_name());
9994 } 9993 }
9995 9994
9996 // More than one entry in the set means that the subframe frame navigation 9995 // More than one entry in the set means that the subframe frame navigation
9997 // entries didn't have a consistent unique name. This will break history 9996 // entries didn't have a consistent unique name. This will break history
9998 // navigations =( 9997 // navigations =(
9999 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!"; 9998 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!";
10000 } 9999 }
10001 10000
10002 } // namespace content 10001 } // namespace content
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698