Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2840873002: [scheduler] Rename member variables from task_runner_ to task_queue_. (Closed)

Created:
3 years, 8 months ago by altimin
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Rename member variables from task_runner_ to task_queue_. Rename *_task_runner_ member variables to *_task_queue_ to match variable type. BUG=710063 Review-Url: https://codereview.chromium.org/2840873002 Cr-Commit-Position: refs/heads/master@{#467320} Committed: https://chromium.googlesource.com/chromium/src/+/c756f829942e5160b135e337d6408047346aa133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -83 lines) Patch
M third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 14 chunks +24 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
altimin
PTAL
3 years, 8 months ago (2017-04-25 14:20:02 UTC) #3
Sami
lgtm, thank you!
3 years, 8 months ago (2017-04-25 18:26:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840873002/1
3 years, 8 months ago (2017-04-26 13:39:20 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 14:20:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c756f829942e5160b135e337d640...

Powered by Google App Engine
This is Rietveld 408576698