Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2840863002: [heap] MC: Refactor page evacuation (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] MC: Refactor page evacuation Evacuators shoud know their associated collector and thus figure out the marking state themselves. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2840863002 Cr-Commit-Position: refs/heads/master@{#44864} Committed: https://chromium.googlesource.com/v8/v8/+/8887945e90dcae78df7ead48ecb965f36d57081d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M src/heap/mark-compact.h View 3 chunks +22 lines, -0 lines 1 comment Download
M src/heap/mark-compact.cc View 8 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
ptal https://codereview.chromium.org/2840863002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/2840863002/diff/1/src/heap/mark-compact.h#newcode567 src/heap/mark-compact.h:567: return MarkingState::Internal(object); These should be the only getters ...
3 years, 8 months ago (2017-04-25 14:14:38 UTC) #2
ulan
lgtm
3 years, 8 months ago (2017-04-25 14:28:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840863002/1
3 years, 8 months ago (2017-04-25 14:45:15 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:46:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8887945e90dcae78df7ead48ecb965f36d5...

Powered by Google App Engine
This is Rietveld 408576698