Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2840853002: Revert of [d8] console methods must not throw. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [d8] console methods must not throw. (patchset #1 id:1 of https://codereview.chromium.org/2838143002/ ) Reason for revert: Breaks no-intl builds. Original issue's description: > [d8] console methods must not throw. > > R=jarin@chromium.org > BUG=chromium:714696 > > Review-Url: https://codereview.chromium.org/2838143002 > Cr-Commit-Position: refs/heads/master@{#44854} > Committed: https://chromium.googlesource.com/v8/v8/+/87b5b53f6f3321ad33b15e686590da7b57df2ff9 TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:714696 Review-Url: https://codereview.chromium.org/2840853002 Cr-Commit-Position: refs/heads/master@{#44856} Committed: https://chromium.googlesource.com/v8/v8/+/95d53ffee15e73a6423284bfedb1403c12633d47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M src/builtins/builtins-console.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/d8-console.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/message/console.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/console.out View 1 chunk +0 lines, -7 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-714696.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yang
Created Revert of [d8] console methods must not throw.
3 years, 8 months ago (2017-04-25 14:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840853002/1
3 years, 8 months ago (2017-04-25 14:00:50 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:01:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/95d53ffee15e73a6423284bfedb1403c126...

Powered by Google App Engine
This is Rietveld 408576698