Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2840823002: Whitelisted tabs permission (Closed)

Created:
3 years, 8 months ago by Ivan Šandrk
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelisted tabs permission Follow up to crrev.com/2830903003 - forgot to actually whitelist the permission. BUG=709513 Review-Url: https://codereview.chromium.org/2840823002 Cr-Commit-Position: refs/heads/master@{#466995} Committed: https://chromium.googlesource.com/chromium/src/+/a3ffd81079c26b22f412c3ad670060d8349d264c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ivan Šandrk
Hey Drew, missed this one as well. Ptal!
3 years, 8 months ago (2017-04-25 12:47:26 UTC) #4
Andrew T Wilson (Slow)
lgtm
3 years, 8 months ago (2017-04-25 15:11:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840823002/1
3 years, 7 months ago (2017-04-25 15:14:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 15:19:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3ffd81079c26b22f412c3ad6700...

Powered by Google App Engine
This is Rietveld 408576698